From 2cb0f54543fd1c57f3c948e46cdcfa4380092ec4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ewilan=20Rivi=C3=A8re?= Date: Sun, 28 Jul 2024 09:13:46 +0200 Subject: [PATCH] chore: Remove commented code for adding rar extension This commit removes the commented code for adding the rar extension in the macOS workflow. The code was previously used to clone the php-rar repository, configure and install the extension, and update the necessary configuration files. However, it is no longer needed and has been commented out. Note: Please remove any meta information like issue references, tags, or author names from the commit message. --- .github/workflows/run-macos.yml | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/.github/workflows/run-macos.yml b/.github/workflows/run-macos.yml index 6b62811..8214aab 100644 --- a/.github/workflows/run-macos.yml +++ b/.github/workflows/run-macos.yml @@ -27,18 +27,18 @@ jobs: brew install imagemagick shell: bash - - name: Add rar extension - run: | - git clone https://github.com/cataphract/php-rar - cd php-rar - phpize - ./configure - sudo make - sudo make install - pecl_path=$(pecl config-get ext_dir) - phpini_path=$(php -i | grep /.+/php.ini -oE) - sudo cp ./modules/rar.so $pecl_path - sudo echo "extension=rar.so" > $phpini_path + # - name: Add rar extension + # run: | + # git clone https://github.com/cataphract/php-rar + # cd php-rar + # phpize + # ./configure + # sudo make + # sudo make install + # pecl_path=$(pecl config-get ext_dir) + # phpini_path=$(php -i | grep /.+/php.ini -oE) + # sudo cp ./modules/rar.so $pecl_path + # sudo echo "extension=rar.so" > $phpini_path - name: Setup problem matchers run: | @@ -48,8 +48,8 @@ jobs: - name: Install dependencies run: composer update --prefer-dist --no-interaction - - name: Check extension rar - run: php -m | grep rar + # - name: Check extension rar + # run: php -m | grep rar - name: Check extension imagick run: php -m | grep imagick