Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Quick POC for #2823 #2920

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

WIP: Quick POC for #2823 #2920

wants to merge 2 commits into from

Commits on Sep 21, 2022

  1. WIP: Quick POC for #2823 

    Upstream todo:

- enable testing with GitHub Actions in django-tabular-permissions
- Add tests for their Demo app, make sure that it works with latest
  Django
- Fix anything that needs fixing

Then:

- Extend django-tabular-permissions to display additional text from
  apps/models. For AppConfig we can use doc-string or custom attribute.
  For models we can only use doc-string b/c it seems custom attributes
  on the Meta class aren't suported! Nor is a Meta doc-string!

Then:

- Update to the appropriate django-tabular-permissions version and
- Document each app & model

Also TODO:
- Some models aren't needed, filter them out of the query set
- Do the same for TenantGroup model
    @atodorov
    atodorov committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    09c4a64 View commit details
    Browse the repository at this point in the history

  2. Format code with black

    @deepsource-autofix
    deepsource-autofix[bot] authored Sep 21, 2022
    Configuration menu
    Copy the full SHA
    5ec6ae7 View commit details
    Browse the repository at this point in the history