use featurizer name in feature name of all featurizers

[kjappelbaum]

No description provided.

[maddy020]

Hey @kjappelbaum
Please elaborate the issue , Which file needs a change ?
I would like to contribute over this issue

[kjappelbaum]

Hey @maddy020, thanks so much for your interest in this issue and thanks for asking for more details.

In all featurizers, we use a class with the following structure

class MyFeaturizer(MOFBaseFeaturizer): 
     def _featurize(self, structure): 
           ...

     def featurize(self, mof):
         ... 

     def feature_labels(self):
         ...

where MyFeaturizer().feature_labels() returns a list of str with the names for the elements of the array that MyFeaturizer().featurize() produces.

Currently, all names start with some string I hard-coded by hand, e.g. "APRDF". However, it would be more useful if it were the class name or something else that can be programmatically inspected.

The simplest improvement might be to include the class name (__name__) as the prefix for all the feature names, e.g.

class MyFeaturizer(MOFBaseFeaturizer): 
     def _featurize(self, structure): 
           ...

     def featurize(self, mof):
         ... 

     def feature_labels(self):
         return [f"{self.__name__}_{a}" for a in oldnames]

[dhruvthakur2000]

hi @kjappelbaum do you mean the result should be in this form f"{class_name}_{name}"

[kjappelbaum]

yep, that would make sense!