-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use featurizer name in feature name of all featurizers #431
Comments
Hey @kjappelbaum |
Hey @maddy020, thanks so much for your interest in this issue and thanks for asking for more details. In all featurizers, we use a class with the following structure class MyFeaturizer(MOFBaseFeaturizer):
def _featurize(self, structure):
...
def featurize(self, mof):
...
def feature_labels(self):
... where Currently, all names start with some string I hard-coded by hand, e.g. "APRDF". However, it would be more useful if it were the class name or something else that can be programmatically inspected. The simplest improvement might be to include the class name ( class MyFeaturizer(MOFBaseFeaturizer):
def _featurize(self, structure):
...
def featurize(self, mof):
...
def feature_labels(self):
return [f"{self.__name__}_{a}" for a in oldnames] |
hi @kjappelbaum do you mean the result should be in this form f"{class_name}_{name}" |
yep, that would make sense! |
No description provided.
The text was updated successfully, but these errors were encountered: