Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the exclusion list to separate module and better indicate why they are excluded #1

Open
kjappelbaum opened this issue Apr 2, 2020 · 1 comment
Open

Move the exclusion list to separate module and better indicate why they are excluded #1

kjappelbaum opened this issue Apr 2, 2020 · 1 comment
Assignees
@kjappelbaum
Labels
enhancement New feature or request

Comments

@kjappelbaum
Copy link
Owner

Currently there is one long list in the class and I started mixing up structures that are excluded because they are special test structures, due to EDA or due to errors found in some previous iterations of the model. We should clean this in separate lists that we import from a separate module. Generally, in the longer run, this part of the code also needs to be fixed as it is really stupid and slow to loop over all this list for each structure. One can easily improve it quite a lot using e.g. sets.
@kjappelbaum kjappelbaum added the enhancement New feature or request label Apr 2, 2020
@kjappelbaum kjappelbaum self-assigned this Apr 2, 2020
@kjappelbaum
Copy link
Owner Author

Moved to separate module in 737e0ca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kjappelbaum kjappelbaum

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kjappelbaum