Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix CI and skipped tests missed in rebase #294

Merged
merged 1 commit into from
Sep 26, 2023
Merged

fix: fix CI and skipped tests missed in rebase #294

merged 1 commit into from
Sep 26, 2023

Conversation

Eikix
Copy link
Member

@Eikix Eikix commented Sep 26, 2023 •
edited
Loading

Time spent on this PR:

Resolves: #

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

@Eikix Eikix force-pushed the fix/fix_ci_failing_and_skipped_tests branch from 6eb1b4f to fccd63f Compare September 26, 2023 11:23
greged93
greged93 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@greged93 greged93 added this pull request to the merge queue Sep 26, 2023
Merged via the queue into kkrt-labs:main with commit b1720e2 Sep 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greged93 greged93 greged93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eikix @greged93