Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add stWalletTest testsuite #431

Merged
merged 5 commits into from
Oct 2, 2023
Merged

add stWalletTest testsuite #431

merged 5 commits into from
Oct 2, 2023

Conversation

TAdev0
Copy link
Contributor

@TAdev0 TAdev0 commented Sep 30, 2023

Time spent on this PR: 15min

#427

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

@khaeljy
Copy link
Contributor

khaeljy commented Sep 30, 2023

I think you've missed a few errors:

 Suite: BlockchainTests/GeneralStateTests/stWalletTest (at /home/runner/work/ef-tests/ef-tests/crates/ef-testing/ethereum-tests/BlockchainTests/GeneralStateTests/stWalletTest)
Ran 42 tests (37 passed, 5 failed, 0 skipped) 

[!] Case /home/runner/work/ef-tests/ef-tests/crates/ef-testing/ethereum-tests/BlockchainTests/GeneralStateTests/stWalletTest/walletConfirm.json failed:
walletConfirm_d0g0v0_Shanghai expected balance 0x0000000000000000000000000000000000000000000000000000000000000009, got 0x0
[!] Case /home/runner/work/ef-tests/ef-tests/crates/ef-testing/ethereum-tests/BlockchainTests/GeneralStateTests/stWalletTest/walletExecuteOverDailyLimitMultiOwner.json failed:
walletExecuteOverDailyLimitMultiOwner_d0g0v0_Shanghai expected storage value 0x00000000000000000000000000000000296cd3823267fa5bebc02e090063c36d for 0xec0e71ad0a90ffe1909d27dac207f7680abba42d, got 0x0000000000000000000000000000000049c83d7507e4746010425e1dfbfb88ca
[!] Case /home/runner/work/ef-tests/ef-tests/crates/ef-testing/ethereum-tests/BlockchainTests/GeneralStateTests/stWalletTest/walletExecuteOverDailyLimitOnlyOneOwner.json failed:
walletExecuteOverDailyLimitOnlyOneOwner_d0g0v0_Shanghai expected storage value 0x00000000000000000000000000000000fce5edbc8e2a8697c15331677e6ebaaa for 0xec0e71ad0a90ffe1909d27dac207f7680abba42d, got 0x0000000000000000000000000000000000000000000000000000000000000000
[!] Case /home/runner/work/ef-tests/ef-tests/crates/ef-testing/ethereum-tests/BlockchainTests/GeneralStateTests/stWalletTest/walletExecuteOverDailyLimitOnlyOneOwnerNew.json failed:
walletExecuteOverDailyLimitOnlyOneOwnerNew_d0g0v0_Shanghai expected storage value 0x00000000000000000000000000000000fce5edbc8e2a8697c15331677e6ebaaa for 0xec0e71ad0a90ffe1909d27dac207f7680abba42d, got 0x0000000000000000000000000000000000000000000000000000000000000000
[!] Case /home/runner/work/ef-tests/ef-tests/crates/ef-testing/ethereum-tests/BlockchainTests/GeneralStateTests/stWalletTest/walletExecuteUnderDailyLimit.json failed:
walletExecuteUnderDailyLimit_d0g0v0_Shanghai expected storage value 0x0000000000000000000000000000000000000000000000000000000000000001 for 0xec0e71ad0a90ffe1909d27dac207f7680abba42d, got 0x0000000000000000000000000000000000000000000000000000000000000000
test blockchain_tests::st_wallet_test ... FAILED

@TAdev0
Copy link
Contributor Author

TAdev0 commented Sep 30, 2023

now everything should be good :) thank you @khaeljy

khaeljy
khaeljy reviewed Sep 30, 2023
View reviewed changes
Copy link
Contributor

@khaeljy khaeljy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

@danilowhk danilowhk enabled auto-merge October 2, 2023 05:37
@danilowhk danilowhk disabled auto-merge October 2, 2023 05:37
@TAdev0
Copy link
Contributor Author

TAdev0 commented Oct 2, 2023

@danilowhk ready to be merged

@danilowhk danilowhk added this pull request to the merge queue Oct 2, 2023
Merged via the queue into kkrt-labs:main with commit 038ada7 Oct 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaeljy khaeljy khaeljy left review comments

@danilowhk danilowhk danilowhk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TAdev0 @khaeljy @danilowhk