Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update devcontainer.json #482

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Update devcontainer.json #482

merged 2 commits into from
Oct 9, 2023

Conversation

khaeljy
Copy link
Contributor

@khaeljy khaeljy commented Oct 6, 2023 •
edited
Loading

Pull Request type

Time spent on this PR: 50min

Update devcontainer to add python, poetry and trunk

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing
  • Dev tools

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Eikix
Eikix approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
PS: we might delete the dependency to python soon, in #488
Letting you know in case it gets merged

@Eikix Eikix added this pull request to the merge queue Oct 9, 2023
Merged via the queue into kkrt-labs:main with commit ce90d63 Oct 9, 2023
3 checks passed
@khaeljy khaeljy deleted the update-devcontainer branch October 11, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eikix Eikix Eikix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khaeljy @Eikix