refactor: refactor according to clippy pedantic recommendation and add more documentation #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greged93
reviewed
Sep 11, 2023
jobez
suggested changes
Sep 11, 2023
There was a problem hiding this comment.
are most of the syntax changes in this PR just running a linter? seems like there are some changes that would be educational to have explained. can you add a comment to the code changes if you think it would be instructive?
by comment, i mean within the PR, not on the code! (would be a good learning opportunity for me, no worries if nothing stands out)
Eikix
commented
Sep 11, 2023
jobez
previously approved these changes
Sep 12, 2023
jobez
dismissed
their stale review
will merge after the underlying dependency issues are resolved
Eikix
force-pushed
the
docs/rustdoc2
branch
from
bd22985 to
afe4dc9
Compare
|
rebased |
Eikix
changed the title
ClementWalter
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR: 0.1day
Resolves #81
Pull Request type
Please check the type of change your PR introduces:
What is the new behavior?
Does this introduce a breaking change?