From 1b86d8acbf828dada35f472fc818249919872723 Mon Sep 17 00:00:00 2001 From: Oak Date: Thu, 22 Feb 2024 07:31:09 +0000 Subject: [PATCH] rm gh token (#988) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This change is [Reviewable](https://reviewable.io/reviews/kkrt-labs/kakarot/988) --------- Co-authored-by: Clément Walter --- .env.example | 1 + .github/workflows/deployments.yml | 1 - .github/workflows/release.yml | 1 - Makefile | 5 ++--- docker/deployer/Dockerfile | 3 --- 5 files changed, 3 insertions(+), 8 deletions(-) diff --git a/.env.example b/.env.example index 3822a720a..5bcaba831 100644 --- a/.env.example +++ b/.env.example @@ -1,4 +1,5 @@ # A Github token to download the CI artifacts +# Used for fetching resources in the scripts GITHUB_TOKEN= # Starkent Network diff --git a/.github/workflows/deployments.yml b/.github/workflows/deployments.yml index 7c4250d2c..93a899b86 100644 --- a/.github/workflows/deployments.yml +++ b/.github/workflows/deployments.yml @@ -16,7 +16,6 @@ jobs: matrix: network: [testnet] env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} ACCOUNT_ADDRESS: ${{ secrets.ACCOUNT_ADDRESS }} PRIVATE_KEY: ${{ secrets.PRIVATE_KEY }} INFURA_KEY: ${{ secrets.INFURA_KEY }} diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index cc12554e6..6e3824ba2 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -33,7 +33,6 @@ jobs: context: . file: ./docker/deployer/Dockerfile platforms: linux/amd64,linux/arm64 - build-args: GITHUB_TOKEN=${{ secrets.GITHUB_TOKEN }} build_and_push_artifacts: runs-on: ubuntu-latest diff --git a/Makefile b/Makefile index b3a8bffea..06e02afdd 100644 --- a/Makefile +++ b/Makefile @@ -23,8 +23,7 @@ endif .PHONY: build test coverage # Kakarot SSJ artifacts for precompiles -KKRT_SSJ_ARTIFACTS_URL = $(shell curl -sL -H "Authorization: token $(GITHUB_TOKEN)" "https://api.github.com/repos/kkrt-labs/kakarot-ssj/actions/workflows/artifacts.yml/runs?per_page=1&branch=main&event=push&status=success" | jq -r '.workflow_runs[0].artifacts_url') -KKRT_SSJ_BUILD_ARTIFACT_URL = $(shell curl -sL -H "Authorization: token $(GITHUB_TOKEN)" "$(KKRT_SSJ_ARTIFACTS_URL)" | jq -r '.artifacts[] | select(.name=="dev-artifacts").url')/zip +KKRT_SSJ_BUILD_ARTIFACT_URL = $(shell curl -L https://api.github.com/repos/kkrt-labs/kakarot-ssj/releases/latest | jq -r '.assets[0].browser_download_url') build: check $(MAKE) clean @@ -40,7 +39,7 @@ check: fetch-ssj-artifacts: rm -rf build/ssj mkdir -p build/ssj - @curl -sL -o dev-artifacts.zip -H "Authorization: token $(GITHUB_TOKEN)" "$(KKRT_SSJ_BUILD_ARTIFACT_URL)" + @curl -sL -o dev-artifacts.zip "$(KKRT_SSJ_BUILD_ARTIFACT_URL)" unzip -o dev-artifacts.zip -d build/ssj rm -f dev-artifacts.zip diff --git a/docker/deployer/Dockerfile b/docker/deployer/Dockerfile index 65a2ea8a1..db646a05a 100644 --- a/docker/deployer/Dockerfile +++ b/docker/deployer/Dockerfile @@ -15,9 +15,6 @@ RUN apt-get update && apt-get install -y --no-install-recommends \ jq \ && rm -rf /var/lib/apt/lists/* -ARG GITHUB_TOKEN -ENV GITHUB_TOKEN=${GITHUB_TOKEN} - # install poetry RUN curl -sSL https://install.python-poetry.org | python3 - ENV PATH="$PATH:/root/.local/bin"