epic: Apply audit results from Kakarot to Keth

[ClementWalter]

Why

This codebase is a copy/paste of Kakarot as of mid septembre. Since then, two audits (C4 and Zellic 2) found issues on it.

What

List all the findings relevant to this context and copy the implemented patches.

How

Last Kakarot PR included in this repo is kkrt-labs/kakarot#1395

• Pick the list of findings relevant for this context
• create an issue per finding and a PR to solve it

Tasks

Beta Give feedback

1. fix: returndata of create txs #143
   +0
   
2. fix: erecover validation #144
   +0
   
3. fix: felt_to_bytes_little loop stop condition #145
   +0
   
4. fix: off by one error ripemd-160 #146
   +0
   
5. fix: finalize dict in ripmed160 #147
   +0
   
6. fix: decode legacy chain id overflow #148
   +0
   
7. fix: set code_address of the deployment code to the created address #149
   +0
   
8. fix: default_dict_copy finalize with default value 0 #150
   +0
9. fix: remove useless computation in uint256_fast_exp #151
   +0
   
10. fix: high offset memory expansion computations #152
    +0
    
11. fix: remove dead code in exec_create #153
    +0
    
12. fix: OOB read in parse_storage_keys on malformated inputs #155
    +0
    
13. fix: memory expansion early return condition #156
    +0
    
14. fix: selfdestruct send to burn address #157
    +0
    
15. fix: undercontrained hint in initialize_jumpdests #158
    +0
    
16. fix: carry bit not checked when transferring funds #160
    +0
    
17. fix: validate s <= N//2 when recovering tx sender #161
    +0
    
18. fix: Several of the stack_size_diff values defined in constants.cairo are off #162
    +0
    
19. fix: some invalid values for the v field in Ethereum signatures are accepted #163
    +0
    
20. fix: extcodehash refactor #165
    +0