Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epic: fix failing tests in nightly #318

Open
3 of 4 tasks
ClementWalter opened this issue Dec 29, 2024 · 2 comments
Open
3 of 4 tasks

epic: fix failing tests in nightly #318

ClementWalter opened this issue Dec 29, 2024 · 2 comments
Assignees
@obatirou
Milestone
EELS migration

Comments

@ClementWalter
Copy link
Member

ClementWalter commented Dec 29, 2024 •
edited by obatirou
Loading

What

See failing test of https://github.com/kkrt-labs/keth/actions/runs/12526214515/job/34938536446

Also limit number of example or strategies for the very long ones

Tasks
Preview Give feedback
@github-project-automation github-project-automation bot moved this to Backlog in Keth Dec 29, 2024
@ClementWalter ClementWalter added this to the EELS migration milestone Dec 29, 2024
@ClementWalter ClementWalter changed the title bug: fix failing tests in nightly epic: fix failing tests in nightly Jan 6, 2025
@ClementWalter ClementWalter moved this from Backlog to Todo in Keth Jan 6, 2025
@obatirou obatirou mentioned this issue Jan 6, 2025
Merged
@obatirou obatirou moved this from Todo to In progress in Keth Jan 6, 2025
obatirou added a commit that referenced this issue Jan 6, 2025
@obatirou
fix: nightly python-version-file path (#363)
d608c8b 
Also fix typo in filename

Part of #318
@obatirou obatirou mentioned this issue Jan 6, 2025
Merged
@obatirou obatirou moved this from In progress to In review in Keth Jan 6, 2025
obatirou added a commit that referenced this issue Jan 6, 2025
@obatirou
dev: limit examples for slow tests (#366)
d6c1657 
Part of #318 

For test > 2000s from
https://github.com/kkrt-labs/keth/actions/runs/12526214515/job/34938536446,
mark those test slow and set the max example to 300.
At time of writing the max_examples for nightly is 1500 hence a division
by 5 but still more than the main ci (which is 100)
@obatirou obatirou mentioned this issue Jan 6, 2025
Merged
enitrat pushed a commit that referenced this issue Jan 6, 2025
@obatirou
ci: fix cache path (#367)
3b2b642 
Part of #318
@obatirou
Copy link
Contributor

obatirou commented Jan 7, 2025

Nightly is failing due to being too long: The timeout-minutes option is not taken into account, it is canceled after 6H by github as the github hosted runners are hosted.
To have more running time (5 days) and use the timeout-minutes option, self hosted runner need to be used.

@ClementWalter
Copy link
Member Author

@nmvalera is this something we could consider?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obatirou obatirou

Labels
None yet
Projects
Keth
Status: In review
Milestone
EELS migration
Development

No branches or pull requests
2 participants
@ClementWalter @obatirou