Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples as code that showcase sample electron apps with usage (and integration with other libs) #298

Open
matmalkowski opened this issue Feb 16, 2021 · 2 comments · Fixed by #299
Labels
chore 🧹 enhancement ✨ v2 All issues related to v2

Comments

@matmalkowski
Copy link
Collaborator

We could have an examples directory, with several simple electron apps, each covering different scenario, and focusing on similar groups that can be tested. Current e2e setup with single instance of electron app is simple, but prevents us from using it for more complex scenarios & integrations with 3rd party libraries

A good started would be examples for those:

  • basic, raw usage -> no 3rd party dependencies, covering manual setup with stateSyncEnhancer
  • more advanced usage -> explicit rendererStateSyncEnhancer & mainStateSyncEnhancer
  • integration with @reduxjs/toolkit
  • integration with redux-saga
  • integration with redux-devtools-extension
  • ...more?

Those examples would live as stand alone packages in example folder, and we could run some integration tests template on them

@dukeeagle
Copy link

Would love to see an example of using @reduxjs/toolkit, if anyone in the community has something!

@rossicler-hostalky
Copy link

Would love to see an example of using @reduxjs/toolkit, if anyone in the community has something!

I'm still looking for that, did you find something you could share?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 🧹 enhancement ✨ v2 All issues related to v2
Projects
None yet
3 participants