Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special dates - Insert public holidays for your/selected country #119

Open
joffer77 opened this issue Jul 12, 2024 · 2 comments
Open

Special dates - Insert public holidays for your/selected country #119

joffer77 opened this issue Jul 12, 2024 · 2 comments

Comments

@joffer77
Copy link

I like the special dates feature. It is good to add special personal dates. It would be awesome if we could also add a specific country's public holidays. Those could be sourced from places like https://www.timeanddate.com/holidays/?allcountries

Adding up on this could be to include option for selecting a second country, in case your spouce/gf/bf/special friend/family is from another country.

@DIntriglia
Copy link

It probably makes sense to implement it via something like this in which the user selects their country.

I could probably whip this up as a MR if interested.

@klimeryk
Copy link
Owner

Nice! I was hoping there'd be an API avaialble for this, thanks for the link! PRs are welcome, @DIntriglia, if you're interested in implementing it.
I'd use the country codes from import dayjsLocales from 'dayjs/locale.json'; (and maybe filter out if something is not supported by the API). Make sure to take into account which year the user chose to generate the calendar for (see PdfConfig.year).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants