Add support for HTTPOption #1251
knative-verify.yaml
on: pull_request
verify
/
Verify Deps and Codegen
1m 58s
Annotations
2 errors and 1 warning
verify / Verify Deps and Codegen:
vendor/knative.dev/networking/test/conformance/ingress/util.go#L1
Please run ./hack/update-codegen.sh.
diff --git a/vendor/knative.dev/networking/test/conformance/ingress/util.go b/vendor/knative.dev/networking/test/conformance/ingress/util.go
index d764b16..b8226f2 100644
--- a/vendor/knative.dev/networking/test/conformance/ingress/util.go
+++ b/vendor/knative.dev/networking/test/conformance/ingress/util.go
@@ -826,7 +826,7 @@ func CreateIngress(ctx context.Context, t *testing.T, clients *test.Clients, spe
// TODO: set the HTTPOption in SetDefaults after release 0.24
setDefaultsForTest(ing)
- //t.Cleanup(func() { clients.NetworkingClient.Ingresses.Delete(ctx, ing.Name, metav1.DeleteOptions{}) })
+ t.Cleanup(func() { clients.NetworkingClient.Ingresses.Delete(ctx, ing.Name, metav1.DeleteOptions{}) })
if err := reconciler.RetryTestErrors(func(attempts int) (err error) {
if attempts > 0 {
t.Logf("Attempt %d creating ingress %s", attempts, ing.Name)
@@ -841,10 +841,10 @@ func CreateIngress(ctx context.Context, t *testing.T, clients *test.Clients, spe
}
return ing, func() {
- //err := clients.NetworkingClient.Ingresses.Delete(ctx, ing.Name, metav1.DeleteOptions{})
- //if err != nil {
- // t.Errorf("Error cleaning up Ingress %q: %v", ingName, err)
- //}
+ err := clients.NetworkingClient.Ingresses.Delete(ctx, ing.Name, metav1.DeleteOptions{})
+ if err != nil {
+ t.Errorf("Error cleaning up Ingress %q: %v", ingName, err)
+ }
}
}
|
verify / Verify Deps and Codegen
Process completed with exit code 1.
|
verify / Verify Deps and Codegen
Restore cache failed: Dependencies file is not found in /home/runner/work/net-gateway-api/net-gateway-api. Supported file pattern: go.sum
|