drop k8s 1.27 from kind testing and add v1.29 #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
size/XS
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #617 +/- ##
=======================================
Coverage 73.12% 73.12%
=======================================
Files 9 9
Lines 692 692
=======================================
Hits 506 506
Misses 157 157
Partials 29 29 ☔ View full report in Codecov by Sentry. |
|
/assign @dprotaso |
|
/retest
…On Fri, Feb 16, 2024 at 17:26 knative-prow[bot] ***@***.***> wrote:
@izabelacg <https://github.com/izabelacg>: The following test *failed*,
say /retest to rerun all failed tests or /retest-required to rerun all
mandatory failed tests:
Test name Commit Details Required Rerun command
integration-tests-istio_net-gateway-api_main 3d23903
<3d23903>
link
<https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-extensions_net-gateway-api/617/integration-tests-istio_net-gateway-api_main/1758615461081124864>
true /test integration-tests-istio
Your PR dashboard <https://prow.knative.dev/pr>.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
Reply to this email directly, view it on GitHub
<#617 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAERAQAOJ6G2GX2SHE6KATYT7MITAVCNFSM6AAAAABDMW74FOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBZGQZDCNRVGQ>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, izabelacg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
PS: Bump of client libraries will happen in knative/pkg#2958