Per KIngress ReferenceGrant

[divanikus]

Changes

🐛 Adds KIngress name to ReferenceGrant name. Helps with per namespace wildcard TLSes.

Fixes #779

/kind bug

[linux-foundation-easycla]

• ❌ - login: @divanikus / name: Andrey . The commit (69fe84c) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: divanikus
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow]

Welcome @divanikus! It looks like this is your first PR to knative-extensions/net-gateway-api 🎉

[knative-prow]

Hi @divanikus. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[skonto]

Hi @divanikus thanks for the contribution! @ReToCode @dprotaso wdyth? The options here are either having a shared grant or one per ingress it seems. One per ingress could potentially create too many RG crs. A shared one would need a way to remove the RG when there are no more Ingresses using it in the target namespace, one option there is to have multiple ownerrefs but not sure if that scales. Another idea in that case, would be to check on ingress deletion whether we need to grant access to the secret anymore.