Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order matters when passing options to NewClient #31

Open
dougwettlaufer opened this issue May 13, 2024 · 0 comments
Open

Order matters when passing options to NewClient #31

dougwettlaufer opened this issue May 13, 2024 · 0 comments

Comments

@dougwettlaufer
Copy link

When passing options to NewClient I noticed that order matters when an http.Client is provided.

This works

knockClient, err := knock.NewClient(
	knock.WithHTTPClient(&http.Client{Transport: GetTracerTransport()}),
	knock.WithAccessToken(knockToken),
)

but if the order is flipped I get a missing token error

knockClient, err := knock.NewClient(
	knock.WithAccessToken(knockToken),
	knock.WithHTTPClient(&http.Client{Transport: cnrtelemetry.GetTracerTransport()}),
)

Seems like this is most likely related to WithHTTPClient stepping directly on the client and wiping out the accessTokenTransport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant