Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModbusMaster use deprecated methods #69

Open
leoandrea7 opened this issue Apr 8, 2021 · 0 comments
Open

ModbusMaster use deprecated methods #69

leoandrea7 opened this issue Apr 8, 2021 · 0 comments

Comments

@leoandrea7
Copy link

Hi, I noticed that in ModbusMaster.java are used deprecated methods.
Indeed inside readHoldingRegisters and readInputRegisters methods the return value is given by response.getRegisters() ​that is deprecated.
Maybe the right return value should be response.getHoldingRegister(), in this way is possible to use convert methods of ModbusHoldingRegisters.class.

The same goes for readCoils and readDiscreteInputs methods.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant