New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import unit tests from rikai #24

Open

da-tubi opened this issue Jan 7, 2023 · 2 comments

Collaborator

da-tubi commented Jan 7, 2023 •

edited

Loading

In #2, we removed failed unit tests directly. Some of them are important unit tests:

`liga/mlflow`

https://github.com/eto-ai/rikai/blob/main/python/tests/spark/sql/codegen/test_mlflow_registry.py
- source code: python/liga/mlflow
- tests: python/test/liga/mlflow
https://github.com/eto-ai/rikai/blob/main/python/tests/spark/sql/codegen/test_mlflow_logger.py
- pytorch to sklearn

`liga/registry`

Move registry related code from https://github.com/liga-ai/liga/tree/v0.2.0.dev1/python/rikai/spark/sql/codegen to python/liga/registry
- enable mypy and pylint for liga/registry
- https://github.com/eto-ai/rikai/blob/main/python/tests/spark/sql/codegen/test_dummy_registry.py
  - change the unit test case from pytorch model type to sklearn model type
- https://github.com/eto-ai/rikai/blob/main/python/tests/spark/sql/codegen/test_fs.py

`liga/sklearn`

https://github.com/eto-ai/rikai/blob/main/python/tests/spark/sql/codegen/test_sklearn_flavor.py

The text was updated successfully, but these errors were encountered:

da-tubi added this to the 4th annual Tubi Hackathon! milestone

Contributor

Renkai commented Jan 9, 2023

working on this.

Renkai mentioned this issue

add test for sklearn #41

Merged

Collaborator Author

da-tubi commented Jan 9, 2023

working on liga/registry part: #45

da-tubi modified the milestones: 4th annual Tubi Hackathon!, v0.2.0

da-tubi removed this from the v0.2.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment