Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excel Blank Rows Calls mutateBeforeCreate #66

Open
byt3sage opened this issue Jan 11, 2023 · 0 comments
Open

Excel Blank Rows Calls mutateBeforeCreate #66

byt3sage opened this issue Jan 11, 2023 · 0 comments

Comments

@byt3sage
Copy link
Contributor

Hey!
First off - great package! It's saved us a lot of upfront time when importing excel spreadsheets.

We have began to notice an issue when a spreadsheet is modified and it introduced blank rows (as in the Excel Special Blank Rows). These 'Blank Rows' cause the mutateBeforeCreate logic etc to be called as they don't get filtered out before hand.

I have a fix for this which I'll fork and PR and I'll put my reasons for the implementation on there - just creating this issue for visibility in case it helps others.

frankyso added a commit that referenced this issue Jan 19, 2023
Excel Blank Rows Calls mutateBeforeCreate (#66)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant