Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make languageCodenames optional for config #58

Open
CollierCZ opened this issue May 7, 2019 · 8 comments
Open

Make languageCodenames optional for config #58

CollierCZ opened this issue May 7, 2019 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers groomed hacktoberfest help wanted Extra attention is needed source-plugin Marking issues related to @kentico/gatsby-source-kontent. up-for-grabs

Comments

@CollierCZ
Copy link
Contributor

Motivation

To simplify configuration for simple, single-language projects -- not require them to add additional options when getting started.

Proposed solution

Make languageCodenames optional in gatsby-config.js with a fallback to default if not provided.

@Simply007
Copy link
Contributor

Also add the note to the Readme.

@Simply007 Simply007 added the source-plugin Marking issues related to @kentico/gatsby-source-kontent. label May 18, 2020
@Hardik0307
Copy link

@makma Want to work on this.

@makma makma assigned makma and Hardik0307 and unassigned makma Oct 13, 2020
@makma
Copy link
Contributor

makma commented Oct 13, 2020

Hello @Hardik0307, welcome to the Kentico community! I've already sent you an invite to the organization and assigned you the issue. Happy coding! 🎉

@Simply007
Copy link
Contributor

Hello @Hardik0307, let me welcome you to Kentico Community as well. I assume you are participating in Hacktoberfest.

I have set "hacktoberfest" topic to this repository so that your pull request would be counted once it is reviewed and merged.

@Hardik0307
Copy link

Hello @Hardik0307, let me welcome you to Kentico Community as well. I assume you are participating in Hacktoberfest.

I have set "hacktoberfest" topic to this repository so that your pull request would be counted once it is reviewed and merged.

Thanks, I've started working!

@Hardik0307
Copy link

I have little doubt that in site's gatsby.config.js changes required or in all gatsby.config.js files.

@makma
Copy link
Contributor

makma commented Oct 20, 2020

Hi @Hardik0307, I'm not sure I understand your question. From my point of view, if you alter the processing of the languageCodenames flag, it won't be necessary to change gatsby configs. Try to suggest some code changes so we can elaborate more on the specific code solution. Thank you!

@Simply007
Copy link
Contributor

The endpoint has been released:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers groomed hacktoberfest help wanted Extra attention is needed source-plugin Marking issues related to @kentico/gatsby-source-kontent. up-for-grabs
Projects
None yet
Development

No branches or pull requests

4 participants