From f99f88d1fa1b7a146a3f52055d12c0576b6a15a7 Mon Sep 17 00:00:00 2001
From: Jeff Ortel <jortel@redhat.com>
Date: Wed, 16 Oct 2024 16:21:40 -0500
Subject: [PATCH] :sparkles: Max DB connections setting. (#759)

Makes the (max) number of DB connections configurable. The default=1
which is:
- The safest.
- Most consistent performance (not necessarily the best) on NFS.
- Matches how <=0.5 has always worked.

Increasing max-connections > 1 provides much better throughput on fast
filesystems.

Signed-off-by: Jeff Ortel <jortel@redhat.com>
---
 database/pkg.go |  8 ++++++++
 settings/hub.go | 15 ++++++++++++---
 2 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/database/pkg.go b/database/pkg.go
index 83cfc4f3..7ee02a59 100644
--- a/database/pkg.go
+++ b/database/pkg.go
@@ -51,6 +51,14 @@ func Open(enforceFKs bool) (db *gorm.DB, err error) {
 		err = liberr.Wrap(err)
 		return
 	}
+	if Settings.DB.MaxConnection > 0 {
+		dbx, nErr := db.DB()
+		if nErr != nil {
+			err = liberr.Wrap(nErr)
+			return
+		}
+		dbx.SetMaxOpenConns(Settings.DB.MaxConnection)
+	}
 	err = db.AutoMigrate(model.PK{}, model.Setting{})
 	if err != nil {
 		err = liberr.Wrap(err)
diff --git a/settings/hub.go b/settings/hub.go
index a215177e..3cfb8427 100644
--- a/settings/hub.go
+++ b/settings/hub.go
@@ -9,6 +9,7 @@ import (
 const (
 	EnvNamespace               = "NAMESPACE"
 	EnvDbPath                  = "DB_PATH"
+	EnvDbMaxCon                = "DB_MAX_CONNECTION"
 	EnvDbSeedPath              = "DB_SEED_PATH"
 	EnvBucketPath              = "BUCKET_PATH"
 	EnvRwxSupported            = "RWX_SUPPORTED"
@@ -45,8 +46,9 @@ type Hub struct {
 	Namespace string
 	// DB settings.
 	DB struct {
-		Path     string
-		SeedPath string
+		Path          string
+		MaxConnection int
+		SeedPath      string
 	}
 	// Bucket settings.
 	Bucket struct {
@@ -127,6 +129,13 @@ func (r *Hub) Load() (err error) {
 	if !found {
 		r.DB.Path = "/tmp/tackle.db"
 	}
+	s, found := os.LookupEnv(EnvDbMaxCon)
+	if found {
+		n, _ := strconv.Atoi(s)
+		r.DB.MaxConnection = n
+	} else {
+		r.DB.MaxConnection = 1
+	}
 	r.DB.SeedPath, found = os.LookupEnv(EnvDbSeedPath)
 	if !found {
 		r.DB.SeedPath = "/tmp/seed"
@@ -135,7 +144,7 @@ func (r *Hub) Load() (err error) {
 	if !found {
 		r.Bucket.Path = "/tmp/bucket"
 	}
-	s, found := os.LookupEnv(EnvRwxSupported)
+	s, found = os.LookupEnv(EnvRwxSupported)
 	if found {
 		b, _ := strconv.ParseBool(s)
 		r.Cache.RWX = b