Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV template for import doesn't contain columns for Owner and Contributors #538

Open
rromannissen opened this issue Oct 20, 2023 · 2 comments · Fixed by #551
Open

CSV template for import doesn't contain columns for Owner and Contributors #538

rromannissen opened this issue Oct 20, 2023 · 2 comments · Fixed by #551
Assignees
@mansam @ibolton336
Labels
priority/release-blocker Must be staffed and worked in time for the next release.

Comments

@rromannissen
Copy link

rromannissen commented Oct 20, 2023 •
edited
Loading

The CSV template used to import applications at scale doesn't contain columns to add information about Owner and Contributors for a given application. Having to add that information manually on a per application basis doesn't scale when managing hundreds or thousands of applications.

The proposal would be to add the following columns:
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Oct 20, 2023
@jortel jortel moved this from 🆕 New to 📋 Backlog in Planning Oct 24, 2023
@jortel jortel moved this from 📋 Backlog to 🔖 Ready in Planning Oct 26, 2023
@mansam mansam self-assigned this Oct 26, 2023
@rromannissen
Copy link
Author

rromannissen commented Nov 3, 2023 •
edited
Loading

Please bear in mind that the CSV template available under the Manage Imports option at the Application Inventory will have to be updated accordingly once this change is implemented.

mansam added a commit to mansam/tackle2-hub that referenced this issue Nov 7, 2023
@mansam
Enable importing app stakeholders
c4d9129 
Adds two fields to the import CSV immediately before tags.
One is for the Owner and should be empty or contain a single
value in the form 'John Doe <jdoe@example.com>'. The second
is for contributors, and should be empty or a list of one or
more values in the previous format, separated by commas. As
this would be a comma-delimited field within a CSV, the whole
value should be surrounded by quotes.

Fixes konveyor#538

Signed-off-by: Sam Lucidi <slucidi@redhat.com>
@mansam mansam mentioned this issue Nov 7, 2023
Merged
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Planning Nov 8, 2023
mansam added a commit that referenced this issue Nov 8, 2023
@mansam
⚠️ Add "owner" and "contributors" columns to application import CSV f…
57bb3f0 
…ormat. (#551)

Adds two fields to the import CSV immediately before tags. One is for
the Owner and should be empty or contain a single value in the form
'John Doe <jdoe@example.com>'. The second is for contributors, and
should be empty or a list of one or more values in the previous format,
separated by commas. As this would be a comma-delimited field within a
CSV, the whole value should be surrounded by quotes. This breaks
compatibility with any existing import CSVs since it adds columns in the
middle (necessary since the number of tags is unbounded and as such the
tag list must come last).

Fixes #538

@jortel Do you think we can get away with adding this to migration 11,
or do you think I should create a new one?

---------

Signed-off-by: Sam Lucidi <slucidi@redhat.com>
@mansam mansam added the priority/release-blocker Must be staffed and worked in time for the next release. label Nov 9, 2023
@rromannissen rromannissen reopened this Nov 21, 2023
@rromannissen
Copy link
Author

@mansam @ibolton336 @dymurray the template under the Manage imports view hasn't been updated to include the Owner and Contributors columns. The current template is not backwards compatible and doesn't work anymore, so this basically blocks the usage of the import feature. Manually adding the Owner and Contributor column after the Repository path column works though, so it looks like it's just a matter of updating the template.

@ibolton336 ibolton336 self-assigned this Nov 21, 2023
@ibolton336 ibolton336 mentioned this issue Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mansam mansam

@ibolton336 ibolton336

Labels
priority/release-blocker Must be staffed and worked in time for the next release.
Projects
Planning
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

⚠️ Add "owner" and "contributors" columns to application import CSV format. mansam/tackle2-hub
3 participants
@mansam @ibolton336 @rromannissen