New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffi/util: remove dead code #1911

Merged

Frenzie merged 1 commit into koreader:master from benoit-pierre:pr/remove_dead_code

Aug 24, 2024

Contributor

benoit-pierre commented Aug 23, 2024 •

edited by Frenzie

Loading

This change is


          ffi/util: remove dead code

f6e50f9

poire-z approved these changes

View reviewed changes

Contributor

poire-z left a comment

The less traces of "Windows" there are, the less likely one will be tempted to assume or make it work :)

Frenzie merged commit 1ed4685 into koreader:master

3 checks passed

Member

Frenzie commented Aug 24, 2024

The rest of the code all uses if ffi.os == "Windows" directly.

benoit-pierre deleted the pr/remove_dead_code branch

August 24, 2024 19:40

NiLuJe added a commit to NiLuJe/koreader that referenced this pull request


          Bump base

5a22cd6

koreader/koreader-base#1894
koreader/koreader-base#1908
koreader/koreader-base#1909
koreader/koreader-base#1904
koreader/koreader-base#1910
koreader/koreader-base#1911
koreader/koreader-base#1912
koreader/koreader-base#1901
koreader/koreader-base#1913
koreader/koreader-base#1680
koreader/koreader-base#1915
koreader/koreader-base#1916
koreader/koreader-base#1914

Frenzie pushed a commit to koreader/koreader that referenced this pull request


          Bump base

896d753

koreader/koreader-base#1894
koreader/koreader-base#1908
koreader/koreader-base#1909
koreader/koreader-base#1904
koreader/koreader-base#1910
koreader/koreader-base#1911
koreader/koreader-base#1912
koreader/koreader-base#1901
koreader/koreader-base#1913
koreader/koreader-base#1680
koreader/koreader-base#1915
koreader/koreader-base#1916
koreader/koreader-base#1914

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet