kopt: improve OCR API #1932
Merged
kopt: improve OCR API #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit-pierre
force-pushed
the
pr/improve_ocr_api
branch
from
744bc53
to
b2f4052
Compare
Frenzie
approved these changes
Sep 9, 2024
Return `nil` (rather than an empty string) when `k2pdfopt_tocr_single_word` failed to initialize tesseract (bad or missing data) so the caller can differentiate with OCR misses (no results).
benoit-pierre
force-pushed
the
pr/improve_ocr_api
branch
from
b2f4052
to
31bbe1f
Compare
benoit-pierre
added a commit
to benoit-pierre/koreader
that referenced
this pull request
Sep 22, 2024
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return
nil(rather than an empty string) whenk2pdfopt_tocr_single_wordfailed to initialize tesseract (bad or missing data) so the caller can differentiate with OCR misses (no results).This change is