-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve file access permissions #18
Comments
Yes, PRs for this are welcome. I think the principle should be that access is never relaxed beyond original permissions (no new users/groups can access the file). It may be ok to skip hardlinking files when the permissions can't be changed to match (limiting dedupe to a single user, or requiring running under sudo). I'm not sure what are the consequences of using ACLs. I'm worried that changing access from old-primitive-unix style could confuse some programs, or users would have harder time undestanding and changing permissions afterwards. |
It would be nice to add an option that ensures that anyone who had access to the file before hardlinking also has access afterwards.
Example:
Before hardlinking:
After hardlinking:
User
bob
has essentially lost write access to the file.Since there are multiple ways of solving this problem, I want to discuss possible solutions, such as:
chown
andchmod g+rw
ifalice
andbob
share a common group.I would be willing on working on the implementation if neccessary.
The text was updated successfully, but these errors were encountered: