Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WeLore #262

Closed
rotem154154 opened this issue Jul 28, 2024 · 2 comments
Closed

Add WeLore #262

rotem154154 opened this issue Jul 28, 2024 · 2 comments
Assignees
Labels
feature request Request features

Comments

@rotem154154
Copy link

Hi,

I really appreciate your work. For me, GaLore has worked the best out of all the optimizers. Could you please consider adding WeLore? It looks promising: https://arxiv.org/abs/2407.11239

Thank you!

@rotem154154 rotem154154 added the feature request Request features label Jul 28, 2024
@kozistr
Copy link
Owner

kozistr commented Jul 31, 2024

thanks i'll check it later!

@kozistr
Copy link
Owner

kozistr commented Sep 2, 2024

@rotem154154 sorry for the late reply. I just checked out the paper and it looks like it's not an optimizer, more like some tools for rank reduction. Also, their implementation only supports the specific parameters depending on the architecture such as LLaMa2 7/13B.

So, I guess it'd be good to wait until they support the model-agnostic parameters and make it easier to use.

I'll reopen this issue when the time comes.

@kozistr kozistr closed this as completed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request features
Projects
None yet
Development

No branches or pull requests

2 participants