chrome 125 results, remove 0 waits

krausest · May 18, 2024 · 3faf4a3 · 3faf4a3
1 parent 895be5d
commit 3faf4a3
Show file tree

Hide file tree

Showing 6 changed files with 219 additions and 230 deletions.
diff --git a/webdriver-ts-results/src/App.tsx b/webdriver-ts-results/src/App.tsx
@@ -48,7 +48,7 @@ const App = () => {
 
   const testEnvironmentInfo = (
     <p>
-      The benchmark was run on a MacBook Pro 14 (32 GB RAM, 8/14 Cores, OSX 14.4), Chrome for Testing 124.0.6367.91
+      The benchmark was run on a MacBook Pro 14 (32 GB RAM, 8/14 Cores, OSX 14.4), Chrome for Testing 125.0.6422.60
       (arm64) using the puppeteer benchmark driver with reduced tracing.
     </p>
   );

diff --git a/webdriver-ts-results/src/results.ts b/webdriver-ts-results/src/results.ts
diff --git a/webdriver-ts/results.json b/webdriver-ts/results.json
diff --git a/webdriver-ts/src/benchmarksPuppeteer.ts b/webdriver-ts/src/benchmarksPuppeteer.ts
@@ -10,7 +10,7 @@ import {
   BenchmarkImpl,
   MemBenchmarkInfo,
 } from "./benchmarksCommon.js";
-import { config, FrameworkData, puppeteerWait } from "./common.js";
+import { config, FrameworkData } from "./common.js";
 import {
   checkCountForSelector,
   checkElementContainsText,
@@ -44,14 +44,12 @@ export let benchRun = new (class extends CPUBenchmarkPuppeteer {
     await checkElementExists(page, "pierce/#run");
     for (let i = 0; i < this.benchmarkInfo.warmupCount; i++) {
       await clickElement(page, "pierce/#run");
-      await puppeteerWait();
       await checkElementContainsText(
         page,
         "pierce/tbody>tr:nth-of-type(1)>td:nth-of-type(1)",
         (i * 1000 + 1).toFixed()
       );
       await clickElement(page, "pierce/#clear");
-      await puppeteerWait();
       await checkElementNotExists(page, "pierce/tbody>tr:nth-of-type(1000)>td:nth-of-type(1)");
     }
   }
@@ -73,7 +71,6 @@ export const benchReplaceAll = new (class extends CPUBenchmarkPuppeteer {
     await checkElementExists(page, "pierce/#run");
     for (let i = 0; i < this.benchmarkInfo.warmupCount; i++) {
       await clickElement(page, "pierce/#run");
-      await puppeteerWait();
       await checkElementContainsText(
         page,
         "pierce/tbody>tr:nth-of-type(1)>td:nth-of-type(1)",
@@ -228,14 +225,12 @@ export const benchRunBig = new (class extends CPUBenchmarkPuppeteer {
     await checkElementExists(page, "pierce/#run");
     for (let i = 0; i < this.benchmarkInfo.warmupCount; i++) {
       await clickElement(page, "pierce/#run");
-      await puppeteerWait();
       await checkElementContainsText(
         page,
         "pierce/tbody>tr:nth-of-type(1)>td:nth-of-type(1)",
         (i * 1000 + 1).toFixed()
       );
       await clickElement(page, "pierce/#clear");
-      await puppeteerWait();
       await checkElementNotExists(page, "pierce/tbody>tr:nth-of-type(1000)>td:nth-of-type(1)");
     }
   }

diff --git a/webdriver-ts/src/common.ts b/webdriver-ts/src/common.ts
@@ -179,4 +179,3 @@ export const wait = (delay = 1000) => {
   else return new Promise((res) => setTimeout(res, delay));
 };
 
-export const puppeteerWait = () => wait(config.PUPPETEER_WAIT_MS);
diff --git a/webdriver-ts/src/forkedBenchmarkRunnerPuppeteer.ts b/webdriver-ts/src/forkedBenchmarkRunnerPuppeteer.ts
@@ -7,7 +7,6 @@ import {
   ErrorAndWarning,
   FrameworkData,
   Config,
-  puppeteerWait,
   wait,
 } from "./common.js";
 import { startBrowser } from "./puppeteerAccess.js";
@@ -93,11 +92,9 @@ async function runCPUBenchmark(
       //     downloadThroughput: 780 * 1024 / 8, // 780 kb/s
       //     uploadThroughput: 330 * 1024 / 8, // 330 kb/s
       // });
-      await puppeteerWait();
 
       console.log("initBenchmark");
       await initBenchmark(page, benchmark, framework);
-      await puppeteerWait();
 
       // let categories = ["blink.user_timing", "devtools.timeline", "disabled-by-default-devtools.timeline"];
       // "blink", "cc","toplevel","v8","benchmark","gpu","viz"
@@ -136,17 +133,14 @@ async function runCPUBenchmark(
         categories: categories,
       });
       await wait(50);
-      await puppeteerWait();
 
       await forceGC(page);
-      await puppeteerWait();
 
       console.log("runBenchmark");
       // let m1 = await page.metrics();
 
       await runBenchmark(page, benchmark, framework);
 
-      await puppeteerWait();
       await wait(100);
       await page.tracing.stop();
       // let m2 = await page.metrics();