Check permissions for /rest/documents #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is really a show-stopper for permission-based user accounts, as it makes the whole authentication quite useless right now because even if you don't see the items in the WebGIS, everybody can still get every document via |
does not cover the case of multiple indices for a single document yet, and also misses tests so far (but confirmed to work locally, for the case of one index entry per quakeml document)
(not tested so far)
|
Here's a first shot at this issue. So far most likely does not properly cover the case of multiple index entries for a single document.. Also no tests so far.. |
megies
commented
Sep 28, 2017
| pass | ||
| queryset = queryset.model.objects.get_filtered_queryset( | ||
| document_type="quakeml", | ||
| queryset=queryset, public=True) |
There was a problem hiding this comment.
This might have to be changed now with 533339b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are correctly checked for
/rest/document_indicesbut should of course also be checked for/rest/documents.