Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on neovim 0.9 + #35

Closed
saifulapm opened this issue Mar 22, 2023 · 19 comments
Closed

Not working on neovim 0.9 + #35

saifulapm opened this issue Mar 22, 2023 · 19 comments

Comments

@saifulapm
Copy link

Hello, On neovim nighty, It's not working. Just cashing neovim.
Screenshot 2023-03-22 at 6 47 42 AM

@krivahtoo
Copy link
Owner

Share your neovim and OS versions.

@cschmatzler
Copy link

cschmatzler commented Mar 22, 2023

Same for me, running :Silicon is crashing neovim.

❯ v --version
NVIM v0.9.0-dev-2473+g3285cd6ec-dirty
Build type: Release
LuaJIT 2.1.0-beta3

config:

return {
  "krivahtoo/silicon.nvim",
  build = "./install.sh build",
  cmd = { "Silicon" },
  opts = {
    font = "Iosevka Nerd Font=21",
    theme = "Catppuccin-latte"
  }
}

macOS 13.1

@krivahtoo
Copy link
Owner

@cschmatzler Is there an error message on crash?

@saifulapm
Copy link
Author

No error. Just exit Neovim.

@cschmatzler
Copy link

Can confirm this - nvim closes as if I ran :q.

@saifulapm
Copy link
Author

Yes. And If I don't lazyload Silicon.nvim, then It don't allow to enter neovim. Exit on start.

@bezlant
Copy link

bezlant commented Mar 26, 2023

It seems to not be working for me on Arch Linux with nvim 0.9, but works on MacOS with the same 0.9 nvim version. I hope I can use it on my arch too <3

@krivahtoo
Copy link
Owner

Yeah, I just updated my nightly and it seems to be broken on the latest nightly

@krivahtoo
Copy link
Owner

8bbcd5b should fix this lmk if not

@chris-av
Copy link

chris-av commented Apr 9, 2023

@krivahtoo didn't appear to fix it for me. I have 8bbcd5b in my git history for the repo. Currently using nvim 0.9.0 and on 2016 Macbook Pro. I updated neovim today and that's how I found this bug.

Similar behavior as the others: running nvim . shows blank screen and then it just exits. No errors printed on the screen. Happens when I require('silicon').

The regular silicon command works on my terminal. I made sure to update it to the latest version.

@bezlant
Copy link

bezlant commented Apr 10, 2023

Same here. My neovim crashes if I have require('silicon')
I'm using Arch Linux. Works on my Macbook though.

@chris-av
Copy link

@bezlant Dunno if this helps, but I got mine to work by doing the following:

  1. comment out the silicon package from your packer install.
  2. purge it from your package manager, in my case, :PackerClean
  3. uncomment out the line from your package manager. Reinstall fresh. This time, I built from source ("install.sh build")

Just checked and it works for me now.

@Feel-ix-343
Copy link

Doesn't work still

@bezlant
Copy link

bezlant commented Apr 27, 2023

@chris-av thank you, unfortunately didn't help.
After updating to neovim 0.9 it keeps crashing on both my linux and mac

@krivahtoo krivahtoo reopened this Apr 28, 2023
@krivahtoo
Copy link
Owner

I have been quite busy lately. I will work on this as soon as I can.

@michaelrommel
Copy link

michaelrommel commented May 1, 2023

Interestingly enough I experimented with Emoji fonts today, on the 0.9.0 version on macOS Ventura.
With

font = 'VictorMono Nerd Font=34; Noto Color Emoji'

the image is generated, but no emojis show. With

font = 'VictorMono Nerd Font=34; Apple Color Emoji'

neovim crashes. I do not know whether this helps in narrowing down the issue. I have lazy loaded the plugin, so it loads only on the :%Silicon command.

Update: now I tested this on WSL2 (the linux subsystem of Windows). The shared lib was rust compiled fine, but if I start it with require('silicon').setup() then neovim crashes immediately.

If I put a very simple opts table in the setup() call (containing only

{ background = "#1d2021" }

then I get the error:

Failed to run config for silicon.nvim
Value of type () couldn't be pushed on the stack: "\'complete\' used without \'nargs\'"
# stacktrace:
 - ~/.config/miro/lua/plugins/init.lua:619 _in_ **config**

@michaelrommel
Copy link

michaelrommel commented May 4, 2023

Hi,
as I was having trouble using the rust binding and was having crashes, I looked at an alternative. The standalone silicon tool worked for me on all platforms that I am using, so I thought about using that as external call.

I created a pure lua plugin, that covers the standard funtionality and also took inspiration from your idea of gobbling.

If you are interested, the plugin lives here: https://github.com/michaelrommel/nvim-silicon

Thank you for this inspiration.

Michael.

@krivahtoo
Copy link
Owner

This should be fixed via 06a4549

@krivahtoo krivahtoo pinned this issue May 12, 2023
@herschel-ma
Copy link

herschel-ma commented Jan 1, 2024

I encounted some questions.
OS:win 10,
nvim: 0.9.4.

I can't even run install.sh with nvim-oxi 0.3.0.
here is the error when I ran cargo build --release in git bash:

error[E0412]: cannot find type `PathBuf` in this scope
   --> C:\Users\Administrator\.cargo\git\checkouts\nvim-oxi-68d2fdc1d1cdbe82\53ceec5\crates\oxi-types\src\string.rs:157:23
    |
157 | impl From<String> for PathBuf {
    |                       ^^^^^^^ not found in this scope
    |
help: consider importing this struct
    |
3   + use std::path::PathBuf;
    |

So I forked this repo and updated nvim-oxi to version 0.4.1, and changed function
image.write_to first param in clipboard.rs so that I can compile it.

But when I added require('silicon') in my config and restarted nvim, it quits immediately, without any messages as same as before.

Does this plugin support windows OS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants