Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect validation error for property data type mismatch in the search space JSON #137

Open
shreyabiradar07 opened this issue Apr 11, 2023 · 0 comments

Comments

@shreyabiradar07
Copy link

The expected data type for the experiment_id property is string. However, if an integer or double value is provided in the search space for e.g in the below JSON, it results in a validation error with the message Parameters cannot be empty or null! . The correct validation error message should indicate that the data type of "experiment_id" should be a string i.e Parameter 'experiment_id' 123 is not of type 'string'

{
  "operation": "EXP_TRIAL_GENERATE_NEW",
  "search_space": {
    "experiment_name": "exp1",
    "experiment_id": 123,
    "total_trials": 5 ,
    "parallel_trials": 1,
    "value_type": "double",
    "hpo_algo_impl": "optuna_tpe",
    "objective_function": "transaction_response_time",
    "tunables": [
      {
        "value_type": "double",
        "lower_bound": 150,
        "name": "memoryRequest",
        "upper_bound": 300,
        "step": 1
      },
      {
        "value_type": "double",
        "lower_bound": 1,
        "name": "cpuRequest",
        "upper_bound": 3,
        "step": 0.01
      }
    ],
    "direction": "minimize"
  }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant