Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes triggered regridding on identical grids issue #87

Merged
merged 8 commits into from
Oct 29, 2024

Conversation

ks905383
Copy link
Owner

  • Moves process_weights, which homogenizes weights and the input ds, from after subsetting to a bounding box to before that process, which prevents regridding to be triggered on otherwise identical weights and ds grids, if a bounding box is used (which can lead to an error if xesmf is not installed)
  • Adds a warning if inputted weights don't span the entirety of the ds (this happens irrespective of the extent of the geodataframe inputted, however, which could lead to spurious warnings if the weight file spans the geodataframe but the ds covers a larger area)
  • Adds tests to make sure the above warning is correctly triggered and weights and ds are jointly subset to bbox correctly.

Closes #86

@ks905383 ks905383 merged commit d3d5103 into main Oct 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

weights on same grid as data seems to still require xesmf
1 participant