Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes triggered regridding on identical grids issue #87

Merged
merged 8 commits into from
Oct 29, 2024
Merged

Fixes triggered regridding on identical grids issue #87

merged 8 commits into from
Oct 29, 2024

Commits on Oct 29, 2024

  1. Address bbox subsetting weights bug

    @ks905383
    ks905383 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    cb0b062 View commit details
    Browse the repository at this point in the history

  2. make sure weights subset warning is in the right place

    @ks905383
    ks905383 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    44d9c6f View commit details
    Browse the repository at this point in the history

  3. add warnings import that I had forgotten

    @ks905383
    ks905383 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    3f2caec View commit details
    Browse the repository at this point in the history

  4. Fix groupby deprecation warnings in dot product calc

    @ks905383
    ks905383 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    e979fe8 View commit details
    Browse the repository at this point in the history

  5. Trigger missingoverlap warning test only if xesmf in env

    @ks905383
    ks905383 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    9a3d983 View commit details
    Browse the repository at this point in the history

  6. Implement non-deprecated pandas groupby in dotprod impl 

    Using https://stackoverflow.com/questions/78542997/deprecation-warning-with-groupby-apply-problem-using-with-lambda-and-group/78543185#78543185 to keep the grouping column and silence the warning.
    @ks905383
    ks905383 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    31d91d9 View commit details
    Browse the repository at this point in the history

  7. remove weights bbox subsetting since already captured by ds

    @ks905383
    ks905383 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    2ebbd06 View commit details
    Browse the repository at this point in the history

  8. finish writing test for #86

    @ks905383
    ks905383 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    06c9bbc View commit details
    Browse the repository at this point in the history