Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding goleak for fixing goroutine leaks in KubeArmor #1910

Open
Manik2708 opened this issue Dec 9, 2024 · 4 comments
Open

Adding goleak for fixing goroutine leaks in KubeArmor #1910

Manik2708 opened this issue Dec 9, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@Manik2708
Copy link

Feature Request

Short Description

Managing Go-Routines is critical and can lead to performance issues if too many go routines are leaked. So adding uber/goleak to tests would be benificial in enhancing the performance of KubeArmor.

Is your feature request related to a problem? Please describe the use case.

It can indeed become a problem when KubeArmor will become more complex and big, like for many CNCF projects (jaeger etc)

Describe the solution you'd like

We can start by integrating our tests with go-leak and ofcourse there would be some leakages, if they are inevetable then we can create a script to ignore goleak in those components otherwise fix them!

@Manik2708 Manik2708 added the enhancement New feature or request label Dec 9, 2024
@Manik2708
Copy link
Author

@nyrahul @daemon1024 @rksharma95 Please express your views on this!

@Pushpendra24-7
Copy link

@Manik2708 I want to work on this issue could you please help on how can I contribute because I am a first time contributer

@Manik2708
Copy link
Author

Hi @Pushpendra24-7! Currently I am waiting for maintainers to express their views whether it is even necessary or not. Currently the KubeArmor team is busy in Kubecon India, if this issue is approved then we will start working on it. Meanwhile you can try fixing some good first issues!

@Pushpendra24-7
Copy link

Ok then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants