Skip to content
This repository has been archived by the owner on Dec 2, 2021. It is now read-only.

is model_type restricted or just a string? #79

Open
ryandawsonuk opened this issue Jul 1, 2019 · 2 comments
Open

is model_type restricted or just a string? #79

ryandawsonuk opened this issue Jul 1, 2019 · 2 comments

Comments

@ryandawsonuk
Copy link

I see the example where it has value 'neural network' and appears to be a sting. I'm wondering whether there are plans to restrict it to a limited range of values or have a convention to avoid differences of wording e.g. 'neural network' vs 'nn'.

I'm also wondering whether this is enough or there should be a 'model_architecture' vs 'model_type'. For instance, you might have a NN handing image data and another handling tabular data - those are quite different things. It could also be important for other components in the cluster to be able to discover whether models handle images, tabular data or text. For example, there might be a need to look up the training data for the model and this could be in a different place for images.

@ryandawsonuk ryandawsonuk changed the title is model_type restricted or just a sting? is model_type restricted or just a string? Jul 1, 2019
@zhenghuiwang
Copy link
Contributor

It is intended to be free-form string type. If some organizations want to enforce a set of canonical type names, they can always define the constant strings in a lib and ask people to use them.

On the other hand, if we enforce constant string type by default, adding new constants for unknown use cases becomes difficult.

There are many use cases that current metadata fields aren't enough to help. We will add them later based on CUJs that we want to enable.

@jtfogarty
Copy link

/kind question
/area engprod
/priority p2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants