Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Enhance/optimise current implementation of processing newly added Job Frameworks. #2837

Open
3 tasks
ChristianZaccaria opened this issue Aug 15, 2024 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@ChristianZaccaria
Copy link
Contributor

This is a follow-up issue to PR #2574: Start JobFramework controller and webhook on new CRDs availability.

What would you like to be added:
Enhance/optimise current design and implementation of #2574

Why is this needed:

  • Current implementation works as expected, however, it could be enhanced with:
    • Enhance current design and implementation of PR: Start JobFramework controller and webhook on new CRDs availability. As part of this issue, we would want to further discuss on other more optimal alternatives to the functionality in place. Please find in this thread the main points of discussion.
    • Only start waitForAPI() once the CRD is registered (wait either by controller or watcher on CRD type).
    • Watching CRDs directly with apiextensions. Once we discover a new CRD, then we start waiting for the restmapper to be filled.
    • One go-routine for all frameworks as opposed to one per framework.
    • Include integration tests aligned with enhanced implementation.

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

@ChristianZaccaria ChristianZaccaria added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 15, 2024
@ChristianZaccaria ChristianZaccaria changed the title Enhance/optimise current implementation of processing newly added Job Frameworks. [Discussion] Enhance/optimise current implementation of processing newly added Job Frameworks. Aug 15, 2024
@mimowo
Copy link
Contributor

mimowo commented Sep 9, 2024

Just a little bit of motivation, this will allow us:

  • reduce the amount of logging for not installed CRDs
  • shorten the time for the API to be ready - currently due to the exponential backoff the detection of API is likely to take 2min (max period). if we start active polling after the CRD is installed the REST mapper will be detected quickly.

I think an integration test can be added even to the current mechanism, so I think it makes sense to keep #3015 open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants