Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmd): add local-config annotation on create #5798

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(cmd): add local-config annotation on create #5798

wants to merge 1 commit into from

Conversation

bt-macole
Copy link

@bt-macole bt-macole commented Nov 8, 2024 •
edited
Loading

this adds a DefaultMetadata object in konfig that can be used when creating a new kustomization yaml that conforms with the best practice recommendations in the kustomize docs.

The Kustomization config in a kustomization.yaml
SHOULD contain this annotation so that tools know it is not intended to be sent to
the Kubernetes api server.

resolves: #5746

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 8, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @bt-macole. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bt-macole
Once this PR has been reviewed and has the lgtm label, please assign knverey for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 8, 2024
@stormqueen1990
Copy link
Member

Hi there, @bt-macole!

The commit message in this PR is currently invalid because commit messages cannot contain closing keywords, at (@) mentions or hashtag (#) references, as per #5798 (comment)

Could you please amend this commit message to fix the issue?

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 8, 2024
@bt-macole
Copy link
Author

Hi there, @bt-macole!

The commit message in this PR is currently invalid because commit messages cannot contain closing keywords, at (@) mentions or hashtag (#) references, as per #5798 (comment)

Could you please amend this commit message to fix the issue?

done! ty

@bt-macole bt-macole force-pushed the issue-5746 branch 2 times, most recently from aa573f3 to 94fad6a Compare November 12, 2024 21:11
stormqueen1990
stormqueen1990 reviewed Nov 13, 2024
View reviewed changes
Copy link
Member

@stormqueen1990 stormqueen1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cc @varshaprasad96 for maintainer review

kustomize/commands/create/create_test.go Outdated Show resolved Hide resolved
kustomize/commands/create/create_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2024
@bt-macole
feat(cmd): add local-config annotation on create
b4be2bd 
this adds a DefaultMetadata object in konfig that can be used
when creating a new kustomization yaml that conforms with the
best practice recommendations in the kustomize docs.

> The `Kustomization` config in a `kustomization.yaml`
> **SHOULD** contain this annotation so that tools know it is not intended to be sent to
> the Kubernetes api server.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2024
@stormqueen1990
Copy link
Member

/test all

stormqueen1990
stormqueen1990 reviewed Nov 18, 2024
View reviewed changes
Copy link
Member

@stormqueen1990 stormqueen1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2024
@bt-macole
Copy link
Author

per this comment

/assign knverey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stormqueen1990 stormqueen1990 stormqueen1990 left review comments

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@stormqueen1990 stormqueen1990

@KnVerey KnVerey

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kustomize create should add config.kubernetes.io/local-config annotation
4 participants
@bt-macole @k8s-ci-robot @stormqueen1990 @KnVerey