Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): provide CNI only for linux #10145

Merged
merged 1 commit into from
Apr 30, 2024
Merged

chore(build): provide CNI only for linux #10145

merged 1 commit into from
Apr 30, 2024

Conversation

jakubdyszkiewicz
Copy link
Contributor

Checklist prior to review

Build is broken after #10101 because it has incompatible changes. Builds without ci/run-full-matrix builds only linux version. That's why it passed the CI on branch.

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@jakubdyszkiewicz
chore(build): provide CNI only for linux
c59f52a 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Apr 30, 2024
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner April 30, 2024 11:17
@jakubdyszkiewicz jakubdyszkiewicz requested review from Automaat, lobkovilya and lukidzi and removed request for a team April 30, 2024 11:17
@jakubdyszkiewicz jakubdyszkiewicz enabled auto-merge (squash) April 30, 2024 11:54
@jakubdyszkiewicz jakubdyszkiewicz merged commit cb8ac9a into kumahq:master Apr 30, 2024
37 checks passed
lobkovilya pushed a commit that referenced this pull request May 15, 2024
@jakubdyszkiewicz @lobkovilya
chore(build): provide CNI only for linux (#10145)
8986ecb 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukidzi lukidzi lukidzi approved these changes

@Automaat Automaat Awaiting requested review from Automaat Automaat is a code owner automatically assigned from kumahq/kuma-maintainers

@lobkovilya lobkovilya Awaiting requested review from lobkovilya lobkovilya is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakubdyszkiewicz @lukidzi