Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support linting Stalark packages #1228

Closed
h4ck3rk3y opened this issue Sep 4, 2023 · 3 comments · Fixed by #1360 or #1354
Closed

Support linting Stalark packages #1228

h4ck3rk3y opened this issue Sep 4, 2023 · 3 comments · Fixed by #1360 or #1354
Assignees
Labels

Comments

@h4ck3rk3y
Copy link
Contributor

h4ck3rk3y commented Sep 4, 2023

Background & motivation

kurtosis-tech/eth-network-package#54
ethpandaops/ethereum-package#109

We don't have liniting

Desired behaviour

We want something like

kurtosis lint .
kurtosis lint /path/to/file.star

How important is this to you?

Painful; the lack of this feature makes using Kurtosis frictionful.

@github-actions github-actions bot added the painful Painful bug label Sep 4, 2023
@h4ck3rk3y h4ck3rk3y self-assigned this Sep 4, 2023
@mieubrisse
Copy link
Collaborator

IMO, UX should be:
kurtosis lint . (if you pass in a directory, we recursively search for all .star files and lint them according to Kurtosis Starlark rules)
kurtosis lint something.star (if you pass in a Starlark file, you'll lint just that file)
kurtosis lint . something.star something-else.star (you can pass in multiple files and directories and Kurtosis will apply all linting rules to each of them)

Documentation note: the docs should have very clear description of what linting rules we're using. The ideal is that we're purely calling down to another very-well-established linter, so users who are familiar with that linter can just use those rules. This gives the extra benefit of, we don't need to build exclusion rules (e.g. # linter-ignore: blahblahblah) by hand

@h4ck3rk3y
Copy link
Contributor Author

@mieubrisse Agreed on the above!

@h4ck3rk3y
Copy link
Contributor Author

h4ck3rk3y commented Sep 14, 2023

  • convert asser to verify PR
  • release the docker version In Progress
  • support pooling + release the KT version

h4ck3rk3y added a commit that referenced this issue Sep 21, 2023
## Description:
Adds a way to lint starlark files

## Is this change user facing?
YES

## References (if applicable):
Closes #1228
h4ck3rk3y pushed a commit that referenced this issue Sep 21, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.83.5](0.83.4...0.83.5)
(2023-09-21)


### Features

* add service details to EM UI
([#1352](#1352))
([2ccd98d](2ccd98d))
* added ability to lint Starlark packages
([#1360](#1360))
([f4a072c](f4a072c)),
closes [#1228](#1228)
* Support YAML as Package param
([#1350](#1350))
([e33bfe6](e33bfe6))


### Bug Fixes

* tail logs from end of log file
([#1339](#1339))
([b8d5816](b8d5816))
* warn instead of failing for json log line parse error
([#1336](#1336))
([44b2820](44b2820))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants