-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support linting Stalark packages #1228
Comments
IMO, UX should be: Documentation note: the docs should have very clear description of what linting rules we're using. The ideal is that we're purely calling down to another very-well-established linter, so users who are familiar with that linter can just use those rules. This gives the extra benefit of, we don't need to build exclusion rules (e.g. |
@mieubrisse Agreed on the above! |
|
## Description: Adds a way to lint starlark files ## Is this change user facing? YES ## References (if applicable): Closes #1228
🤖 I have created a release *beep* *boop* --- ## [0.83.5](0.83.4...0.83.5) (2023-09-21) ### Features * add service details to EM UI ([#1352](#1352)) ([2ccd98d](2ccd98d)) * added ability to lint Starlark packages ([#1360](#1360)) ([f4a072c](f4a072c)), closes [#1228](#1228) * Support YAML as Package param ([#1350](#1350)) ([e33bfe6](e33bfe6)) ### Bug Fixes * tail logs from end of log file ([#1339](#1339)) ([b8d5816](b8d5816)) * warn instead of failing for json log line parse error ([#1336](#1336)) ([44b2820](44b2820)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Background & motivation
kurtosis-tech/eth-network-package#54
ethpandaops/ethereum-package#109
We don't have liniting
Desired behaviour
We want something like
kurtosis lint .
kurtosis lint /path/to/file.star
How important is this to you?
Painful; the lack of this feature makes using Kurtosis frictionful.
The text was updated successfully, but these errors were encountered: