Which part of the code handles identifying moves as fishy?

[jrlodge]

I'm working on an API that uses PKHeX as a dependency and I'd like to add a check for whether moves are fishy, in this case, I believe Bestow is given the caution icon in the GUI because it is an event-only move, but I can't find which part of the code identifies a move as fishy.

I know there's the LegalityAnalysis.Results:

CheckResult { Judgement = Valid, Identifier = Encounter, Comment = Able to hatch an Egg at Met Location., Valid = True, Rating = Valid }
CheckResult { Judgement = Valid, Identifier = Evolution, Comment = Valid., Valid = True, Rating = Valid }
CheckResult { Judgement = Valid, Identifier = Nickname, Comment = Nickname does not match another species name., Valid = True, Rating = Valid }
CheckResult { Judgement = Fishy, Identifier = EVs, Comment = All EVs are zero, but leveled above Met Level., Valid = True, Rating = Fishy }
CheckResult { Judgement = Valid, Identifier = Level, Comment = Current level is not below met level., Valid = True, Rating = Valid }
CheckResult { Judgement = Valid, Identifier = Ribbon, Comment = All ribbons accounted for., Valid = True, Rating = Valid }
CheckResult { Judgement = Valid, Identifier = Ability, Comment = Ability matches ability number., Valid = True, Rating = Valid }
CheckResult { Judgement = Valid, Identifier = Ball, Comment = Ball possible for species., Valid = True, Rating = Valid }
CheckResult { Judgement = Valid, Identifier = Form, Comment = Form is Valid., Valid = True, Rating = Valid }
CheckResult { Judgement = Valid, Identifier = Form, Comment = Form argument is valid., Valid = True, Rating = Valid }
CheckResult { Judgement = Fishy, Identifier = Encounter, Comment = Pokémon HOME Transfer Tracker is missing., Valid = True, Rating = Fishy }

But there's nothing in here about moves being fishy. I'm looking for whatever part triggers the caution icon in the GUI.

An optional setting to set these warnings to invalidate the Pokemon could potentially be good, as this example, Pikachu in SV is untradeable but is seen as legal by PKHeX.

Any help would be appreciated, thanks.

[sora10pls]

That is not a "fishy move", that indicator is there for moves that a Pokémon can have in its moveset in SWSH from past games, but is unusable in SWSH. The implementation in PKHeX matches what Pokémon HOME does.

Starting with BDSP, moves get reset to match the target game's learnset, but PKHeX still stores byte arrays for usable/unusable moves for each given context. In your example, Bestow is not usable in SV, so PKHeX yields the yellow error icon.

[jrlodge]

Makes sense, thanks.

Do you happen to know how I can access these byte arrays for a given Pokemon object? If there's no built-in function for checking if a move is unusable in a given context I should be able to do some manual checks comparing the Pokemon's moves against usable moves.

Is it something to do with this PKHeX.Core/Editing/PKM/LegalMoveInfo.cs ?

I'm working with Pokemon objects created by GetLegalFromTemplate, my API takes showdown sets and returns EKX bytes.

[kwsch]

PKHeX/PKHeX.Core/Moves/MoveInfo.cs

Line 100 in aa841ae

public static bool IsDummiedMove(PKM pk, int index)