Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Truncated deep links #3484

Merged
merged 6 commits into from
Nov 20, 2024

Conversation

akucharska
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Don't truncate buttons
  • Show more buttons on details

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 18, 2024
@akucharska akucharska linked an issue Nov 18, 2024 that may be closed by this pull request
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 18, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 20, 2024
@akucharska akucharska merged commit 3dd2283 into kyma-project:main Nov 20, 2024
15 checks passed
@akucharska akucharska deleted the truncated-deep-links branch November 20, 2024 13:41
pbochynski pushed a commit to pbochynski/busola that referenced this pull request Dec 6, 2024
* fix: truncated deep links

* Show buttons

* Fix separator and spacing

* Fix tests

* Fix tests

* Fix modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deep links in overview section are hidden and truncated
3 participants