From d8295194ba9284ecf9002e3b33655ae0afb7d021 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Przemys=C5=82aw=20Golicz?= <przemyslaw.golicz@sap.com>
Date: Thu, 5 Dec 2024 12:28:47 +0100
Subject: [PATCH] Handing missing Disabled field in OIDC extension data to
 avoid crash

---
 .../internal/runtime/migrator.go              |  3 +
 .../runtime/fsm/runtime_fsm_configure_oidc.go |  3 +
 .../fsm/runtime_fsm_configure_oidc_test.go    | 68 +++++++++++++++++++
 3 files changed, 74 insertions(+)

diff --git a/hack/runtime-migrator/internal/runtime/migrator.go b/hack/runtime-migrator/internal/runtime/migrator.go
index d8b6052c..8f61b651 100644
--- a/hack/runtime-migrator/internal/runtime/migrator.go
+++ b/hack/runtime-migrator/internal/runtime/migrator.go
@@ -224,6 +224,9 @@ func getControlPlane(shoot v1beta1.Shoot) *v1beta1.ControlPlane {
 func checkIfShootNetworkFilteringEnabled(shoot v1beta1.Shoot) bool {
 	for _, extension := range shoot.Spec.Extensions {
 		if extension.Type == ShootNetworkingFilterExtensionType {
+			if extension.Disabled == nil {
+				return true
+			}
 			return !(*extension.Disabled)
 		}
 	}
diff --git a/internal/controller/runtime/fsm/runtime_fsm_configure_oidc.go b/internal/controller/runtime/fsm/runtime_fsm_configure_oidc.go
index 433cc3f0..51c6f6bc 100644
--- a/internal/controller/runtime/fsm/runtime_fsm_configure_oidc.go
+++ b/internal/controller/runtime/fsm/runtime_fsm_configure_oidc.go
@@ -114,6 +114,9 @@ func deleteExistingKymaOpenIDConnectResources(ctx context.Context, client k8s_cl
 func isOidcExtensionEnabled(shoot gardener.Shoot) bool {
 	for _, extension := range shoot.Spec.Extensions {
 		if extension.Type == extender.OidcExtensionType {
+			if extension.Disabled == nil {
+				return true
+			}
 			return !(*extension.Disabled)
 		}
 	}
diff --git a/internal/controller/runtime/fsm/runtime_fsm_configure_oidc_test.go b/internal/controller/runtime/fsm/runtime_fsm_configure_oidc_test.go
index f3e1639c..ba44e156 100644
--- a/internal/controller/runtime/fsm/runtime_fsm_configure_oidc_test.go
+++ b/internal/controller/runtime/fsm/runtime_fsm_configure_oidc_test.go
@@ -160,6 +160,74 @@ func TestOidcState(t *testing.T) {
 		assertEqualConditions(t, expectedRuntimeConditions, systemState.instance.Status.Conditions)
 	})
 
+	t.Run("Should not crash and configure OIDC using defaults when Disabled field is missing in extension data", func(t *testing.T) {
+		// given
+		ctx := context.Background()
+
+		// start of fake client setup
+		scheme, err := newOIDCTestScheme()
+		require.NoError(t, err)
+		var fakeClient = fake.NewClientBuilder().
+			WithScheme(scheme).
+			Build()
+		testFsm := &fsm{K8s: K8s{
+			ShootClient: fakeClient,
+			Client:      fakeClient,
+		},
+			RCCfg: RCCfg{
+				Config: config.Config{
+					ClusterConfig: config.ClusterConfig{
+						DefaultSharedIASTenant: createConverterOidcConfig("defaut-client-id"),
+					},
+				},
+			},
+		}
+		GetShootClient = func(
+			_ context.Context,
+			_ client.Client,
+			_ imv1.Runtime) (client.Client, error) {
+			return fakeClient, nil
+		}
+		// end of fake client setup
+
+		runtimeStub := runtimeForTest()
+		shootStub := shootForTest()
+		oidcService := gardener.Extension{
+			Type:     "shoot-oidc-service",
+			Disabled: nil,
+		}
+		shootStub.Spec.Extensions = append(shootStub.Spec.Extensions, oidcService)
+
+		systemState := &systemState{
+			instance: runtimeStub,
+			shoot:    shootStub,
+		}
+
+		expectedRuntimeConditions := []metav1.Condition{
+			{
+				Type:    string(imv1.ConditionTypeOidcConfigured),
+				Reason:  string(imv1.ConditionReasonOidcConfigured),
+				Status:  "True",
+				Message: "OIDC configuration completed",
+			},
+		}
+
+		// when
+		stateFn, _, _ := sFnConfigureOidc(ctx, testFsm, systemState)
+
+		// then
+		require.Contains(t, stateFn.name(), "sFnApplyClusterRoleBindings")
+
+		var openIdConnects authenticationv1alpha1.OpenIDConnectList
+
+		err = fakeClient.List(ctx, &openIdConnects)
+		require.NoError(t, err)
+		assert.Len(t, openIdConnects.Items, 1)
+
+		assertOIDCCRD(t, "kyma-oidc-0", "defaut-client-id", openIdConnects.Items[0])
+		assertEqualConditions(t, expectedRuntimeConditions, systemState.instance.Status.Conditions)
+	})
+
 	t.Run("Should configure OIDC based on Runtime CR configuration", func(t *testing.T) {
 		// given
 		ctx := context.Background()