-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRD structure prepared #24
Conversation
Is this PR still a WiP? I'm unable to find the following parts:
|
@@ -10,7 +10,7 @@ repo: github.com/kyma-project/cluster-inventory | |||
resources: | |||
- api: | |||
crdVersion: v1 | |||
namespaced: true | |||
namespaced: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Project Config(...) will store all plugins and input data used to generate the project and APIs to better enable plugins to make useful decisions when scaffolding.
Should anything else be adjusted (or re-scaffolded ?) after this change? It's just not clear to me how this setting is exactly used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did run make test
and nothing was changed. I assume the change in CRD is enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GardenerCluster sample looks ok
Description
This PR defines contract between the Kyma Environment Broker, and the Infrastructure Manager.
There are the following assumptions:
GardenerCluster
should be in 1:1 relation with shootGardenerCluster
instanceGardenerCluster
CR should be namespacedRuntimeID
.Changes proposed in this pull request:
Related issue(s)
#9