Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRD structure prepared #24

Merged
merged 9 commits into from
Sep 14, 2023
Merged

CRD structure prepared #24

merged 9 commits into from
Sep 14, 2023

Conversation

akgalwas
Copy link
Contributor

@akgalwas akgalwas commented Sep 12, 2023

Description

This PR defines contract between the Kyma Environment Broker, and the Infrastructure Manager.
There are the following assumptions:

  • shoot name, and secret name must be passed to the Infrastructure Manager
  • the GardenerCluster should be in 1:1 relation with shoot
  • there will be exactly one secret for a particular GardenerCluster instance
  • properties introduced in the first CR version should be grouped in an object, to allow to extend the CR easily
  • the GardenerCluster CR should be namespaced
  • KEB should create the Gardener Cluster CR in the following manner:
    • CR's name should be the same as RuntimeID.
    • CR's should contain the same set of labels as the secret KEB currently creates

Changes proposed in this pull request:

  • CRD renamed to Gardener Cluster
  • CRD contains secret name, namespace, and key name
  • CRD contains status
  • Example prepared

Related issue(s)
#9

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 12, 2023
@akgalwas akgalwas changed the title CRD renamed CRD structure prepared Sep 12, 2023
@Disper
Copy link
Member

Disper commented Sep 12, 2023

Is this PR still a WiP? I'm unable to find the following parts:

  • CRD contains the following data: shootName, secretName
  • Example prepared

@akgalwas akgalwas added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2023
@akgalwas akgalwas marked this pull request as draft September 12, 2023 07:08
api/v1/gardenercluster_types.go Outdated Show resolved Hide resolved
api/v1/gardenercluster_types.go Outdated Show resolved Hide resolved
api/v1/gardenercluster_types.go Show resolved Hide resolved
@akgalwas akgalwas marked this pull request as ready for review September 12, 2023 16:20
@akgalwas akgalwas requested a review from a team as a code owner September 12, 2023 16:20
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2023
@@ -10,7 +10,7 @@ repo: github.com/kyma-project/cluster-inventory
resources:
- api:
crdVersion: v1
namespaced: true
namespaced: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Project Config(...) will store all plugins and input data used to generate the project and APIs to better enable plugins to make useful decisions when scaffolding.

Should anything else be adjusted (or re-scaffolded ?) after this change? It's just not clear to me how this setting is exactly used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did run make test and nothing was changed. I assume the change in CRD is enough.

Copy link
Member

@piotrmiskiewicz piotrmiskiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GardenerCluster sample looks ok

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 14, 2023
@kyma-bot kyma-bot merged commit 5174362 into kyma-project:main Sep 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants