Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align KIM to use Config Map with converter config #336

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Align KIM to use Config Map with converter config #336

merged 1 commit into from
Aug 9, 2024

Conversation

mvshao
Copy link
Contributor

@mvshao mvshao commented Aug 8, 2024

Description

Changes proposed in this pull request:

  • add Config Map with converter config as Volume Mount to KIM deployment

Related issue(s)
#320

@mvshao mvshao requested a review from a team as a code owner August 8, 2024 12:21
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 8, 2024
koala7659
koala7659 approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 9, 2024
@kyma-bot kyma-bot merged commit 9d98ea2 into kyma-project:main Aug 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koala7659 koala7659 koala7659 approved these changes

Assignees

@koala7659 koala7659

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvshao @koala7659 @kyma-bot