Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes bearerTokenFile and tlsConfig from prometheus service monitor #354

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Removes bearerTokenFile and tlsConfig from prometheus service monitor #354

merged 1 commit into from
Aug 29, 2024

Conversation

Disper
Copy link
Member

@Disper Disper commented Aug 28, 2024

Description

Changes proposed in this pull request:

  • Modification requested by security audit
  • Removes bearerTokenFile and tlsConfig from prometheus service monitor
  • This is used only for local development and not very often
  • Verification would be time consuming and I did not test this change (minimal impact)

@Disper Disper requested a review from a team as a code owner August 28, 2024 09:16
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 28, 2024
@Disper Disper changed the title Removes bearerTokenFile and toldConfig from prometheus service monitor Removes bearerTokenFile and tlsConfig from prometheus service monitor Aug 28, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 29, 2024
@kyma-bot kyma-bot merged commit a9924c4 into kyma-project:main Aug 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiscr tobiscr tobiscr approved these changes

Assignees

@tobiscr tobiscr

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Disper @tobiscr @kyma-bot