Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renames control-manager to intrastructure-manager #93

Merged
merged 3 commits into from
Dec 8, 2023
Merged

renames control-manager to intrastructure-manager #93

merged 3 commits into from
Dec 8, 2023

Conversation

Disper
Copy link
Member

@Disper Disper commented Dec 7, 2023

Description

kubectl -n kcp-system get service infrastructure-manager -o yaml | yq .spec.selector control-plane: controller-manager is pulling 2 other unrelated components' pods.

Changes proposed in this pull request:

  • renaming from controller-manager to infrastructure-manager
  • ...
  • ...

Related issue(s)

@Disper Disper requested a review from a team as a code owner December 7, 2023 12:00
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 7, 2023
@Disper Disper changed the title [WiP] aims to rename selector to intrastructure-manager renames control-manager to intrastructure-manager Dec 7, 2023
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 7, 2023
@gczuczy
Copy link

gczuczy commented Dec 7, 2023

Could you please also add a label to the service's selector labels and its matching pods, which would scope it to be within this deployment?
Something like app.kubernetes.io/component: infrastructure-manager.kyma-project.io would do nicely I think.

koala7659
koala7659 approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 8, 2023
@kyma-bot kyma-bot merged commit 3a1d6fb into kyma-project:main Dec 8, 2023
6 checks passed
@Disper Disper deleted the selector_renaming branch December 11, 2023 07:42
@Disper Disper mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koala7659 koala7659 koala7659 approved these changes

Assignees

@koala7659 koala7659

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Disper @gczuczy @koala7659 @kyma-bot