Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find a method for debugging raft-rs's bytes slice #44

Closed
jopemachine opened this issue Aug 8, 2023 · 2 comments
Closed

Find a method for debugging raft-rs's bytes slice #44

jopemachine opened this issue Aug 8, 2023 · 2 comments
Labels
feature New feature or request upstream-issue

Comments

@jopemachine
Copy link
Member

jopemachine commented Aug 8, 2023 •
edited
Loading

In #43, I added some global functions for debugging raftify in 81ce87b, but it still can not print raft-rs's internal logs through slog

If there could be a possible way to implement this, it should be very useful.
@jopemachine jopemachine added feature New feature or request upstream-issue labels Aug 8, 2023
@jopemachine jopemachine changed the title Find a way method for debugging raft-rs bytes slice Find a method for debugging raft-rs bytes slice Aug 8, 2023
@jopemachine jopemachine changed the title Find a method for debugging raft-rs bytes slice Find a method for debugging raft-rs's bytes slice Aug 8, 2023
@jopemachine
Copy link
Member Author

I'm not sure but defining a custom slog::Drain trait might be needed.

@jopemachine
Copy link
Member Author

This could be resolved in the upstream repository.
I hope this PR tikv/raft-rs#522 could be merged.
But even if it could not be merged, we can make it work by cloning raft-rs and adding a proper trait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request upstream-issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jopemachine