Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Disabling denoise #8

Open
hrj opened this issue Jan 20, 2021 · 2 comments
Open

Feature request: Disabling denoise #8

hrj opened this issue Jan 20, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@hrj
Copy link

hrj commented Jan 20, 2021

According to the discussion here, it is possible to suppress denoising by setting parameter MMAL_PARAMETER_STILLS_DENOISE to MMAL_FALSE.

Can you please expose this through picamerax? It will help immensely with low-light photography.

While we are at it, being able to set MMAL_PARAMETER_CAMERA_ISP_BLOCK_OVERRIDE would be also great. Setting it to ~0x80 apparently disables pixel-correction.

thanks!

@jtc42
Copy link
Member

jtc42 commented Mar 21, 2021

Yeah I’m so sorry I only just saw this. I somehow disabled notifications for this repo and so didn’t see the issue.

I have really limited time to spend on this now, but I’ll certainly look into it. @rwb27 may be able to help too, but again it may be way out of scope.

The other option may be that IIRC the raw bayer data doesn’t include denoising (I may be wrong though) so if that’s the case you can use the bayer data to get what you need.

@jtc42 jtc42 added the enhancement New feature or request label Mar 21, 2021
@rwb27
Copy link

rwb27 commented Aug 17, 2021

Yes, the Bayer data is pre-denoising. If it's a simple parameter to add, it shouldn't be a big job; it's worth noting, though, that the Pi foundation have now got a libcamera interface, which feels like it solves most of the problems we are trying to fix with picamerax - so it might be in the near future that we can abandon picamerax in favour of that other, much clearer interface.

I'll leave this open and look at it if I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants