Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After some time has passed, clean up HVAC component dictionaries #241

Open
chriswmackey opened this issue May 5, 2021 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@chriswmackey
Copy link
Member

Right now, the three template HVAC components contain dictionaries with a lot of extra keys that were meant to help deal with a couple breaking changes that we made in honeybee-schema. The extra dictionaries include the hvac_dict and the vintages dictionary. In another two stable releases after we aren't so concerned about people using the old dropdown list of the HVAC enumerations, we should just simplify the code in these components. We can probably get rid of the hvac_dict and reduce the keys in the vintages dictionary.

@chriswmackey chriswmackey added the enhancement New feature or request label May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant