Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated and old aggregate attestations #1254

Closed
rodrigo-o opened this issue Aug 7, 2024 · 2 comments · Fixed by #1303
Closed

Duplicated and old aggregate attestations #1254

rodrigo-o opened this issue Aug 7, 2024 · 2 comments · Fixed by #1303
Assignees
Labels
bug Something isn't working

Comments

@rodrigo-o
Copy link
Collaborator

Context

During the work on #1244 duplicate attestations generated Invalid Signature errors at the time of block proposals when trying to generate aggregates (the BLS aggregate signature was computing the same aggregator more than once in the signature generated), this didn't happened before making the handle_new_block and handle_tick synchronous (i.e. without removing the GenServer and just converting casts to calls in the ValidatorManager the error was reproduced). A quick solution is already in place:

  # TODO: We need to check why we are producing duplicate attestations, this was generating invalid signatures
  unique_attestations = attestations |> Enum.uniq()

Description
The purpose of this task is two-fold

  1. Understand the root cause of duplicated attestations and fix it
    We are receiving duplicates just from ourselves, this error pop-up only when we are publishing attestations, if we just receive them from other nodes we don't have this issue.

  2. Understand why we are still adding duplicate aggregate attestations in our block proposals (this was happening before refactor: validator manager genserver removal #1244)
    This might be related to the previous one, given that we only uniquely filtered them at the aggregation step this behavior might be affecting also aggregates and not just committee attestations.

Example of a block with duplicated aggregate attestations:

image

@rodrigo-o
Copy link
Collaborator Author

This also happens now with sync_committee_messages as per #1284

@rodrigo-o rodrigo-o changed the title Duplicated aggregate attestations Duplicated and old aggregate attestations Sep 10, 2024
@rodrigo-o
Copy link
Collaborator Author

Additionally this should tackle the issue that we add attestation for slot-2 to our blocks instead of slot-1 as the other nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants